search

endlessm / endless-key-app

Endless Key app for Windows (formerly known as kolibri-app)
https://www.endlessos.org/key
MIT License
2 stars 1 forks source link

electron: Drop USB APIs relating to Welcome screen #148

Closed starnight closed 1 year ago

starnight commented 1 year ago

Since the commit ("Welcome: Drop USB/SD option from Welcome screen") of kolibri-explore-plugin 1 drops the USB option, Endless Key app removes corresponding USB APIs accordingly.

Fixes: https://github.com/endlessm/endless-key-app/issues/145

starnight commented 1 year ago

We have metrics IDs:

If we will not produce Endless USB Key image anymore, and the application kolibri-electron.exe on the USB key is not upgradable, then users still use the original kolibri-electron.exe, which works as before, of course. Then, we can have the commit ("electron: Drop USB APIs relating to Endless USB Key"). On the contrary, we can drop the commit ("electron: Drop USB APIs relating to Endless USB Key") if we will produce new version Endless USB Key image.

erikos commented 1 year ago

I'm not super familiar with the JS portion of this app, but it looks OK to me. However, I think @erikos is needed on the question of whether the Endless Key USB should still be supported or not.

Yes, let's remove the USB standalone support - there are no plans to use this further.