Windows: Spanish setting only applies on the loading screen

endlessm / endless-key-app

Endless Key app for Windows (formerly known as kolibri-app)

https://www.endlessos.org/key

MIT License

2 stars 1 forks source link

Windows: Spanish setting only applies on the loading screen #158

Closed manuq closed 10 months ago

manuq commented 11 months ago

From @vanessa-chang at https://github.com/endlessm/kolibri-explore-plugin/issues/861

In the latest Windows app: 7.4.1.0

OS language settings

The loading screen is in Spanish but the following screens are still in English.

manuq commented 10 months ago

I have opened a PR that is basically a port of (part of) https://github.com/endlessm/kolibri-installer-android/pull/188 . Please note that existing installations would still be in English. Further work is needed for fixing that (add a "Windows plugin" like we have in Android, add a migration script).

erikos commented 10 months ago

I have opened a PR that is basically a port of (part of) endlessm/kolibri-installer-android#188 . Please note that existing installations would still be in English. Further work is needed for fixing that (add a "Windows plugin" like we have in Android, add a migration script).

Nice, thanks a lot! I think the migration could come in a second step, would not block on it.

erikos commented 10 months ago

Works fine in 7.10.427 - QA pass.