search

endlessm / eos-photos

Endless photo application
Other
4 stars 3 forks source link

T11377 #300

Closed tchx84 closed 8 years ago

tchx84 commented 8 years ago

https://phabricator.endlessm.com/T11377

mattdangerw commented 8 years ago

Looks great!

The facebook dialog could still use a bit of work, the buttons got a bit too vertically large think. And if you try opening a lighter colored picture, you can actually see the rounded corners of the dialog are not transparent. There's a little black corner underneath which we should get rid of.

mattdangerw commented 8 years ago

The trough on the slider looks like its still a pixel or two too big.

tchx84 commented 8 years ago

@mattdangerw I covered all* of your comments (and one extra bug with the facebook login dialog). Compared screenshots to make sure it looks the same.

*The only problem I haven't being able to fix is that black background showing up in the dialog window corners (when they are rounded).

Could it be something with GTK?