endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Add filtering functionality for online/offline content to the channel view #569

Open erikos opened 1 year ago

erikos commented 1 year ago

We have landed the capabilities to view content that is not on your device yet. This can be overwhelming if there is a lot of content. The user should be able to filter the view to further edit the view. Filters is something already used in the channel view, this would be another one. All the rest of the view and order of individual items should stay intact.

Screenshot from 2023-06-05 08-33-51 Screenshot from 2023-06-05 08-33-42

manuq commented 1 year ago

Let's consider Search. This is the line that adds no_available_filtering conditionally inside the searchChannelsOnce() method. Insted, that should be a new parameter. Then the SearchPage.vue view would be able to call the method with "filter available" true/false.

jofilizola commented 1 year ago

Current channel layout: image

manuq commented 1 year ago

The control itself could be a BootstrapVue switch style checkbox: https://bootstrap-vue.org/docs/components/form-checkbox#individual-checkbox-switch-style

The spec from @jofilizola shows a checkbox control from Material, but I'm afraid we are using Bootstrap through BootstrapVue. The only exception is that we use icons from Material. Switching entirely to Material would be a bigger change, and mixing UI frameworks is not convenient.

jofilizola commented 1 year ago

The control from Bootstrap is totally fine, I just used the material library for convenience (because of the icons) image

jprvita commented 1 year ago

Moving back to In Progress as I believe this is still missing the switch on initial page when entering a channel. #591 only adds the filter to the search results.

erikos commented 1 year ago

One major piece is missing here that would lead to inconsistency when landing the button to filter on the channel view top level:

manuq commented 1 year ago

Moving to in-progress and assigning @GeorgesStavracas since he is working on this.

erikos commented 1 year ago

Not on the to-do-for-now list anymore, back to the backlog.