Closed manuq closed 11 months ago
Ready for review: #611
I also improved the code by initializing on first API call, rather than on module import.
I also created PRs for the wrapper apps, so they stop bundling the collections.
Let's move to the next iteration to not risk any issues before we get the Ladybug release out.
Let's move to the next iteration to not risk any issues before we get the Ladybug release out.
Sounds good! I'm also unassigning myself so others can take it from here. The PR already got good feedback from @dylanmccall @dbnicholson and @pwithnall .
To smooth the transition here, I am proposing two more PRs which only affect the build system:
I also created a new release for endless-key-collections: https://github.com/endlessm/endless-key-collections/releases/tag/v0.2.0.
Last night I whipped up a PR to publish the endless-key-collections JSON to GitHub Pages. I think we should go back to @manuq's PRs and use https://endlessm.github.io/endless-key-collections/ as the base URL.
Blocking until after ISTE. Please unblock and review again after it.
I'm deassigning myself from this one. Someone else could follow up the PR.
We decided to don't go this way.
Fetch the collection JSON manifests from Github release. Currently we serve them as static files which are included in the wrapper apps (Android, Windows) at build time. This way the collections release will be decupled from software releases.
PRs: