search

endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Only use LZMA compression for channel template zips #794

Closed dbnicholson closed 1 year ago

dbnicholson commented 1 year ago

Having bundle_zip default to LZMA compression meant it also applied to welcome-screen.zip. That's problematic since unzip can't handle that compression scheme. It's also unnecessary as welcome-screen.zip is only intended for releases. All of our apps will expand it into some location in their package, so the compression used is irrelevant.

Instead, make the default zlib deflate compression and explicitly request LZMA compression just for the channel templates. Note that the outer apps-bundle.zip is actually created with no compression, which is fine since it's entirely for distributing the already compressed channel templates.

See https://github.com/endlessm/endless-key-flatpak/issues/26.

dbnicholson commented 1 year ago

I'm going to merge and tag this so we can consume it in the flatpak before we have any more major overhauls from the welcome-screen and internationalization work.