endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Remove package localization #801

Closed dbnicholson closed 1 year ago

dbnicholson commented 1 year ago

The standalone packages have temporary $tr placeholders that don't currently handle translation objects or placeholders. For stable, revert the recent translation changes to essentially go back to the hardcoded English strings. The proper i18n fixes will land on master and full localization can be enabled for the the next major version.

See #797 for an example of current broken translations.

dbnicholson commented 1 year ago

I tested this locally and it seems to get all the expected English strings back.

manuq commented 1 year ago

All reverts look good. Waiting for the CI build to finish.

dbnicholson commented 1 year ago

CI passed. Merging.