search

endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Update to kolibri-tools 0.16.0-dev.4 #814

Closed dbnicholson closed 1 year ago

dbnicholson commented 1 year ago

This has several fixes that we upstreamed and hopefully fixes some strange linting issues in the frontend.

dbnicholson commented 1 year ago

Wait, maybe not just yet. I ran yarn run lint-frontend and it gave a pile of errors that I don't understand:

Kolibri Linter: 
Kolibri Linter: Linting errors for kolibri_explore_plugin/assets/src/views/DiscoveryPageEkIguana.vue
Kolibri Linter: TypeError: Class extends value undefined is not a constructor or null
dbnicholson commented 1 year ago

Wait, maybe not just yet. I ran yarn run lint-frontend and it gave a pile of errors that I don't understand:

Kolibri Linter: 
Kolibri Linter: Linting errors for kolibri_explore_plugin/assets/src/views/DiscoveryPageEkIguana.vue
Kolibri Linter: TypeError: Class extends value undefined is not a constructor or null

The problems go away if I borrow the update to vue-cli 5/webpack 5 from #777.

pwithnall commented 1 year ago

Wait, maybe not just yet. I ran yarn run lint-frontend and it gave a pile of errors that I don't understand:

Kolibri Linter: 
Kolibri Linter: Linting errors for kolibri_explore_plugin/assets/src/views/DiscoveryPageEkIguana.vue
Kolibri Linter: TypeError: Class extends value undefined is not a constructor or null

The problems go away if I borrow the update to vue-cli 5/webpack 5 from #777.

Yeah, I think if you’re doing anything to do with this you’ll want the full stack of changed dependencies from #777.

dbnicholson commented 1 year ago

I split out those commits from #777 and added the change to build with --no-module. I tested this locally and I think it's good on its own. It will cause a small conflict with #793 since it operates on the welcome-screen package. I'm happy to rebase if that lands soon.

dbnicholson commented 1 year ago

It seems to be working now. I think the sass problems magically went away because loading-screen got completely decoupled from ek-components in #793. Still waiting for the apps-bundle build to complete (my god is it slow to webpack 60 apps), but I think this should be good to go.