endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Change KolibriApi translators property to static #826

Closed manuq closed 12 months ago

dbnicholson commented 12 months ago

Quite possibly this is https://stackoverflow.com/questions/60046847/eslint-does-not-allow-static-class-properties? I can't tell what version of eslint we're actually using, but we're inheriting from the kolibri-tools .eslintrc.js and that has ecmaVersion: 2020. See https://eslint.org/blog/2021/10/eslint-v8.0.0-released/.

manuq commented 12 months ago

Eslint fails because class properties aren't considered until eslint v8. Really Javascript?!

manuq commented 12 months ago

Superceeded by #827 which was merged.