endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

locale: Update es-419 translations from in-progress Google Docs sheets #840

Closed pwithnall closed 11 months ago

pwithnall commented 11 months ago

The translations are not yet fully complete, but this gets us a lot closer.

This commit is the result of:

  1. Downloading the Docs sheets as CSVs (see below for links).
  2. Renaming ‘Spanish Translation’ to ‘Translation’ as a column in each of them, as kolibri-tools uses the column names to find translations.
  3. Putting the CSV files in kolibri_explore_plugin/locale/es_419/LC_MESSAGES. Naming doesn’t matter, as long as they have a .csv extension.
  4. Running yarn run i18n-download-translations and selecting only the es-419 changes to be committed.

Google Docs spreadsheets are:

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Helps: #765

pwithnall commented 11 months ago

The obvious steps to improve this process would be:

  1. Rename the columns in the source Google Docs so they’re the right name and don’t need post-processing.
  2. Fix kolibri-tools to actually error if it can’t find the expected column in the CSV, rather than just happily writing out a blank file.

I chose not to make those changes in this PR so we can get it merged asap.

manuq commented 11 months ago

I think you should also remove es-es from kolibri_explore_plugin/locale/language_info.json, right?

It is a bit awkward, but can we keep both es-es and es-419 as duplicate files? Ideally we would have es directly but it doesn't seem to be how kolibri/formatjs wants it?

pwithnall commented 11 months ago

I thought we weren’t targeting es-ES at all?

manuq commented 11 months ago

I thought we weren’t targeting es-ES at all?

I don't know which locale will be used for QA'ing this. Kolibri has both es-419 and es-ES. I wonder if a simple symlink would work in all of our platforms.