Closed pwithnall closed 11 months ago
The obvious steps to improve this process would be:
I chose not to make those changes in this PR so we can get it merged asap.
I think you should also remove
es-es
fromkolibri_explore_plugin/locale/language_info.json
, right?
It is a bit awkward, but can we keep both es-es and es-419 as duplicate files? Ideally we would have es
directly but it doesn't seem to be how kolibri/formatjs wants it?
I thought we weren’t targeting es-ES at all?
I thought we weren’t targeting es-ES at all?
I don't know which locale will be used for QA'ing this. Kolibri has both es-419 and es-ES. I wonder if a simple symlink would work in all of our platforms.
The translations are not yet fully complete, but this gets us a lot closer.
This commit is the result of:
kolibri_explore_plugin/locale/es_419/LC_MESSAGES
. Naming doesn’t matter, as long as they have a.csv
extension.yarn run i18n-download-translations
and selecting only the es-419 changes to be committed.Google Docs spreadsheets are:
Signed-off-by: Philip Withnall pwithnall@endlessos.org
Helps: #765