search

endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Run content pack selection even if channels exist #863

Closed dbnicholson closed 10 months ago

dbnicholson commented 11 months ago

Currently the pack selection is skipped if any channels exist under the assumption that only happens once the pack has been selected. That prevents the content from being preseeded as we're trying to do in the image builder with the result that the Discovery page is empty.

manuq commented 11 months ago

So we should persist the pack selection somewhere. Or use the lack of download state as evidence of "pack hasn't been selected". Maybe the latter, otherwise current users will get a pack selection once again.

manuq commented 11 months ago

Ready for review. This will need careful testing of all possible cases: English, Spanish, download paused/resumed by closing/reopening the app. I tried in Spanish (automatic ES pack selected) and worked fine.

manuq commented 11 months ago

OK, I have found an issue with the previous PR when a download was attempted in a new session even after the download was completed in a previous session. Not good! This new PR should fix it: https://github.com/endlessm/kolibri-explore-plugin/pull/870

This makes the get_should_resume API a bit irrelevant. But honestly I don't want to make further changes without a test suit.

dbnicholson commented 11 months ago

I merged that and it got released in 7.7.0. If there are any further issues, I think we should open a new issue.

dbnicholson commented 11 months ago

I opened #874 about using the database to persist the download state and pack selection in a more reliable way.

vanessa-chang commented 10 months ago

So far, no issues were found on the latest Android and Windows package for resuming the content download.

I will close this issue first.