search

endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
2 stars 4 forks source link

Download content pack even when there is content #866

Closed manuq closed 11 months ago

manuq commented 11 months ago

Change the assumption for showing the welcome screens: before, when there was content in the database it was assumed to be already downloaded and the download was skipped. Now rely on the presence of a DOWNLOAD_COMPLETED state persisted.

Fix #863

manuq commented 11 months ago

Looks good to me if you can clean up the debug message. One of these days I'll learn how all the routing works...

The routing is a pain. I have checked in latest Kolibri and the situation didn't improve. So Kolibri has a wrapper around vue-router which plugins use passing a routes object. But also Kolibri has a SET_PAGE_NAME and the current page is used to display a different component in the root view (in our case in the ExplorePlugin). And in the same root has a <router-view />. This is kind of redundant. The Vue Router library should take care of mapping routes to components and display them in the router-view directly, as in the very beggining of their getting started guide: https://router.vuejs.org/guide/

It would also be nice to store the download state in the backend database someday.

Yeah.. that was the idea when implementing content packs management (install more packs, remove packs, etc).