search

endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
1 stars 4 forks source link

build: Copy setup.cfg data to pyproject.toml #886

Open pwithnall opened 10 months ago

pwithnall commented 10 months ago

This is needed to use newer versions of kolibri-tools, which will read configuration from pyproject.toml in preference to setup.cfg, if the former exists.

See https://github.com/learningequality/kolibri/issues/11146

For now, keep the old configuration present in setup.cfg as well, in case people are using an older version of kolibri-tools. That can be dropped once we bump our dependency.

pwithnall commented 10 months ago

This is actually only needed once kolibri-explore-plugin depends on a new-enough version of kolibri-tools that contains https://github.com/learningequality/kolibri/issues/11146. At that point, our i18n would break without this PR, because kolibri-tools will read pyproject.toml in preference to setup.cfg, and won’t merge keys between the two.

Submitting this PR now, even though it’s not actually needed yet, to avoid that potential trip hazard in future.

manuq commented 10 months ago

Thank you @pwithnall