endlessm / kolibri-explore-plugin

The kolibri plugin to add the custom channel representation
MIT License
1 stars 4 forks source link

Improve loadingScreen Spanish translation #893

Closed dbnicholson closed 10 months ago

dbnicholson commented 10 months ago

This was discussed in https://github.com/endlessm/kolibri-installer-android/issues/187 and some other places. Currently the loadingScreen Spanish translation isn't used on many Spanish locales. The problem is that the translation loading is done only for an exact locale in navigator.languages without any of the heuristics that Kolibri's library provides. That means that unless navigator.languages includes es-419, you won't get Spanish translations. As was found in https://github.com/endlessm/kolibri-installer-android/issues/187, there are many Android webview cases where this isn't the case.

I think the solution here is simple:

erikos commented 10 months ago

https://github.com/endlessm/kolibri-explore-plugin/pull/894 has been merged. Waiting for a plugin release.

erikos commented 10 months ago

Build 7.10.427 works fine. QA pass.

Image