endlos99 / xdt99

xdt99: TMS 99xx Cross-Development Tools
http://endlos99.github.io/xdt99
GNU General Public License v3.0
52 stars 8 forks source link

Skip first 128 bytes if -t/--tifiles is an argument. Allows listing … #12

Closed christopherkobayashi closed 8 years ago

christopherkobayashi commented 8 years ago

…programs in TIFILES format without altering source.

TIFILES write support is forthcoming in the next few days.

christopherkobayashi commented 8 years ago

Closing pull request -- I didn't notice/realize that --long on the command line will accomplish the same decoding of IV254. I will resubmit the TIFILES header support when I have working write support

endlos99 commented 8 years ago

Chris, I like your proposal. My original thinking was that you'd use

xdm99.py -P some.tfi -o - | xbas99.py -l -

to print a BASIC program in a TIFILE, but I guess that looks really scary. :-) (But it should work even on Windows.)

christopherkobayashi commented 8 years ago

Right, my intention was to make --tifiles work with both stdin and a TIFILES file that's already on disk. This should accomplish both. I understand that xdm99.py operates on both files and disk images; you might want to revisit that decision and rework the embedded help file to reflect which decision you choose.

IMHO the arguments shouldn't be position-dependent (or accurately documented if they are, such as the disk image needing to be argv[1] rather than argv[argc]). I'd be happy to rework the parsing logic to make it more UNIXy if you want.

Further, I finally think I got IV254 decode from TIFILES format working properly (needed to chop out zero pads and the record markers). I'm not sure why I thought they were already working last night, when I reverted my commits and revoked my pull request.

IV254 encode for TIFILES still isn't quite there (the code emitted does not match the code input, and it won't list), and trailing whitespace for BASIC tokens that take optional arguments is still not being removed. I'll issue a big scary pull request when I have that working.

Thanks for accepting my patches. I'd like to see this suite get a wider user base; it has the potential to surpass the tens of Windows applications that the AA guys keep recommending.