search

endocrimes / Jay

Pure-Swift JSON parser & formatter. Fully streamable input and output. Linux & OS X ready. Replacement for NSJSONSerialization.
MIT License
132 stars 19 forks source link

Fix conversion of String->Int dictionary #53

Closed remko closed 7 years ago

remko commented 8 years ago

Failing test for #52

czechboy0 commented 8 years ago

Can you please also add the test of the name to the manifest so that this test is ran on Linux as well? https://github.com/DanToml/Jay/blob/master/Tests/JayTests/FormattingTests.swift#L34

remko commented 8 years ago

Oops, missed that. Fixed.

remko commented 8 years ago

I did an explicit typecheck on Int instead of a cast. Let's see if the Linux builds still succeed.

Note that the inverse (typechecking for Bool) doesn't work; someInt is Bool returns true.

remko commented 8 years ago

Note to self: run the full unit test suite before pushing :( Sorry for the noise, back to the drawing board.

remko commented 8 years ago

Not sure why the build is failing; the tests seem to pass.

codecov-io commented 8 years ago

Current coverage is 88.32% (diff: 81.81%)

Merging #53 into master will decrease coverage by 0.80%

@@             master        #53   diff @@
==========================================
  Files            24         24          
  Lines          1914       1936    +22   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1706       1710     +4   
- Misses          208        226    +18   
  Partials          0          0

Powered by Codecov. Last update 828d8ac...267c7f0

remko commented 7 years ago

Any updates on this? Is there anything I can do to get this merged?

endocrimes commented 7 years ago

Looks like this will need a rebase then it's good to go, sorry for the delay!

remko commented 7 years ago

@DanToml Thanks, done!