Closed usta closed 1 year ago
What do you think @captn3m0 @generalmimon @BiNZGi @hebbet @marcwrobel @adriens ?
@hugovk
Since we already have a clear blockquote (>
) as part of our contribution template, maybe we can just do this in Jekyll. I don't want to define large HTML/markdown blobs in the front-matter. The only exception so far is LTSLabel
where we stuff a abbr
tag, but description feels incorrect.
Seeing if this can be done in liquid.
you are just looking for the frontend side , this will also allow users to get product information though api it will be nice to used in cli applications that show product information which also needs it though api
The code I wrote for #2069 can also be used for the API usecase. Our convention of using a quote for the product description works well here - and it keeps our contributions simpler (Writing markdown inside YAML isn't always easy).
Long-term, I want to use as little Liquid as possible, by doing all of the logic in Ruby, and presenting a simple data model to both the HTML template, and the API layout.
Nice addition @usta / @captn3m0 :+1: !
Product pages without a logo look a little bit strange. Maybe we should add a default logo or remove it entirely in that case ?
@marcwrobel @captn3m0 we can use [prepare same or similar icon for simpleicons] for NA icons
I doubt simpleicons will accept it, but we could try.
We can add it directly in our template as well.
Yep, I was more thinking about that.
I fear choosing a logo for such product will be difficult (like it is for #978): it must be clear that this is not the product logo. So I wonder if it would not be simpler to just drop it for those pages (=> no more space on the left of the description).
i think that logo which i shown above perfect for all applications
I think having a string tag called description/productDescription will nice to have so we can do something like this [1] or [2] , sure also we can easily use it within our api system The main idea is a short version of context will be in this tag [not more than a few lines]
example [1] :
example [2]: