endoflife-date / endoflife.date

Informative site with EoL dates of everything
https://endoflife.date
MIT License
2.49k stars 772 forks source link

Adding Product Logo in sidebar #283

Open usta opened 3 years ago

usta commented 3 years ago

It will be nice to add a new part for tools sections called productLogo or logo so we can put logos with svg formated logo links ( which must be creative common or any open license) that will improve its look visually

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Be sure to follow the issue template!

usta commented 3 years ago

@captn3m0 @BiNZGi ^^

usta commented 3 years ago

I have mentioned as svg which will help us to decide its resolution without losing its quality while rendering

usta commented 3 years ago

also we can use same svg with rendering it as 32x32 in site-nav part so it will help people to select tools much easier

hugovk commented 3 years ago

https://simpleicons.org/ is a good source of CC0 SVG icons, they're also used by https://shields.io/

captn3m0 commented 3 years ago

Simpleicons looks neat. I was also thinking of incorporating icons in the generated visual timeline (small icon at bottom right of the timeline).

Are SVG icons usable as Favicons? Should we use product icons for favicons?

usta commented 3 years ago

yes almost all browser support svg for favicons , but i believe keeping the endoflife's its own favicon same for all pages is a better idea.

On Mon, Jul 5, 2021, 16:12 Nemo @.***> wrote:

Simpleicons looks neat. I was also thinking of incorporating icons in the generated visual timeline (small icon at bottom right of the timeline).

Are SVG icons usable as Favicons? Should we use product icons for favicons?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/endoflife-date/endoflife.date/issues/283#issuecomment-874102530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3R4RXV7P7SIJEM6ZAQPLTWGVSFANCNFSM472OHFGQ .

usta commented 3 years ago

I normally dont want to be "That" guy who always willing to be "grammar nazi" but @captn3m0 isnt this looks better if we use same structure with other tags ? I suggest using camelCase system instead of underscores. I mean using iconSlug instead of icon_slug will be much suitable to keep everything in order

captn3m0 commented 3 years ago

Thanks for the note, will take care of it.

usta commented 3 years ago

I think this one ^^ have forgotten :)

captn3m0 commented 3 years ago

If you're working on this, you will need to extend the nav.html file as a include in our repository from the theme we are using: https://github.com/pmarsceill/just-the-docs/blob/master/_includes/nav.html.

Then, add the relevant HTML/CSS to add the icon to the sidebar to display the icon correctly. Make sure the design looks good (and well-aligned) even if we don't have an icon for the product.

See the icon bits in our product page template: https://github.com/endoflife-date/endoflife.date/blob/53b9a6f4f1a242fd11f68c1a0449eeb594e47856/_layouts/post.html#L205-L209 to make sure you're parsing the field the same way.

Read through very helpful guide for new contributors during Hacktoberfest as well to understand how to setup the project.

sooraj-gk commented 3 years ago

Sir, can I work on this issue

captn3m0 commented 3 years ago

Go ahead, thanks for letting us know 👍🏽

ampsteric commented 2 years ago

hey! , I would be happy to help. Please assign me this issue under hacktoberfest.

usta commented 2 years ago

looks like history repeats itself , first @sooraj-gk then @ampsteric Ok , from now on please nobody asks for a assign this to me thing , just makes a MR/PR and we will check if it is ok or not