endoflife-date / endoflife.date

Informative site with EoL dates of everything
https://endoflife.date
MIT License
2.47k stars 756 forks source link

path of favicon.ico is wrong #978

Closed usta closed 1 year ago

usta commented 2 years ago

https://endoflife.date/favicon.ico doesn't exist and thus it is giving 404 @captn3m0

usta commented 2 years ago

It try to reach favicon like this : https://endoflife.date/favicon.ico <-- 404 but favicon.ico 's path is under assets like https://endoflife.date/assets/favicon.ico

usta commented 2 years ago

And looks like this bug exist but we missed it with other 404s : [this is 2 months ago's logs which you shared ] image

usta commented 2 years ago

@BiNZGi @captn3m0 ping ?

captn3m0 commented 2 years ago

I'd noticed it, but always thought that our favicon wasn't good enough to be used anywhere, so never got around to fixing it.

We have the image we use on GitHub avatar (I cropped it from https://unsplash.com/photos/mn0Kezx98EI), but I don't like it much either.

Any suggestions?

usta commented 2 years ago

i always liked more certain things , it might be much better to use a hourglass because it let you understand it will be finish when its top part finishes. How about normal clocks ? who know what shows 12 ? what is that will it start ? or will it end ? nothing is certain in that image image

BiNZGi commented 2 years ago

I also agree to create a new icon. The hourglass with all the sand down (cycle ended) can be a first idea. Font Awesome has already an icon for that in their library: https://fontawesome.com/icons/hourglass-end?s=duotone

Because of copyright issues it is probably a good idea to create something by our-self or use a free to use graphic.

usta commented 2 years ago

not the all sands down but almost all because otherwise it doest look like a hourgalss but something else when you first look it

marcwrobel commented 1 year ago

Maybe this one : https://openmoji.org/library/emoji-231B/ or https://openmoji.org/library/emoji-23F3/. Their icons are under the CC BY-SA 4.0 license, so all that's required is an attribution in the projects README and on the generated website (next to This site uses Just the Docs, a documentation theme for Jekyll. ?).

marcwrobel commented 1 year ago

This issue is linked to #28.

captn3m0 commented 1 year ago

Anyone wants to file a PR for a favicon to start? (With the openmoji icon)

marcwrobel commented 1 year ago

Sure, I will give it a try.

@captn3m0, I also like the icon you put in the assets directory, it better convey the idea of a "cycle" than an hourglass IMHO : icon

Where does it come from ?

captn3m0 commented 1 year ago

It's from the Material Icon set: https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Aupdate%3A

marcwrobel commented 1 year ago

Material Icons are under Apache 2 license, so we could use them too I think. But let's do a POC first.

marcwrobel commented 1 year ago

I have created two PRs : one with the Openmoji icon (https://github.com/endoflife-date/endoflife.date/pull/1900) and the other with the Material icon (https://github.com/endoflife-date/endoflife.date/pull/1902).

Each PR update the favicon and add the logo next to the site's title. Let me know what you think of it by looking at the deployed site. Personally I prefer the material icon.

usta commented 1 year ago

@marcwrobel @captn3m0 my 2 cent [vote] is for https://github.com/endoflife-date/endoflife.date/pull/1900

Let me expain why a refresh like icon is not suitable: it doesnt match the idea to show end of something it doesnt show the time moving/passing it gives users idea of refresh instead of end it almost disapear on darkthemes systems [ image ]

marcwrobel commented 1 year ago

Thank you very much for taking some time to look at both icons @usta. There is now 1 vote for #1900 and 1 vote for #1902 ;).

usta commented 1 year ago

Let me expain why a refresh like icon is not suitable: it doesnt match the idea to show end of something it doesnt show the time moving/passing it gives users idea of refresh instead of end it almost disapear on darkthemes systems [ image ]

marcwrobel commented 1 year ago

I do not have the same point of view. I think both icons show that time is passing (using a clock and an arrow for the material icon, and a an hourglass for the Openmoji one), but the material icon also shows :

For the dark theme compatibility both icons are nearly invisible. And for both icons it can be improved by adding a solid background to the favicon.ico (I don't know what background color to use though).

marcwrobel commented 1 year ago

@captn3m0, @BiNZGi, any preference between the two logo ?

BiNZGi commented 1 year ago

I am not happy with both versions. The hourglass looks dated like from an old OS or something. The reload with the timing pointer is the wrong icon for the site. I would try another hourglass version, e.g. from https://fontawesome.com/icons/hourglass-half?s=duotone&f=classic

marcwrobel commented 1 year ago

Unfortunately it's not possible to use fontawesome icons because of their license.

And hourglass material icons are not good too IMHO (https://fonts.google.com/icons?selected=Material+Icons+Outlined:update:&icon. Maybe the bootstrap icon ?

hourglass-split

marcwrobel commented 1 year ago

I just found those icons who are in the public domain.

https://publicdomainvectors.org/en/free-clipart/Hourglass-vector-graphics/31382.html : time-clock-publicdomainvectors-org

https://publicdomainvectors.org/en/free-clipart/Simple-hourglass-vector-drawing/12580.html : sanduhr

Is one of those icon ok @BiNZGi, @usta, @captn3m0 ?

Note that I still think that the Material icon (reload with clock) is the better one, as explained in https://github.com/endoflife-date/endoflife.date/issues/978#issuecomment-1327357988 😋.

captn3m0 commented 1 year ago

My vote is for #1902, but not by much. I'm also thinking about the next step - social media images, where I'm thinking of something like the following as a dynamic image for every product to be used for social media shares:

sample k8s summary card image

I think the hourglass works much better here, but I don't like the current version in #1900. Not liking the openclipart options from above either. Clicked through to the original sources:

marcwrobel commented 1 year ago

OK. One thing is sure, the hourglass is the preferred icon. Il will try to find some alternative icons.

In the mean time, I am closing #1902.

marcwrobel commented 1 year ago

Searched a little more for new icons that are free for personal and commercial purpose, here is what I got (I kept @captn3m0's links) :

I we try to agree on an icon I fear we will never choose one. So could you choose the one we will use @captn3m0 (if one suits you of course ;)) ?

marcwrobel commented 1 year ago

@captn3m0 ?

captn3m0 commented 1 year ago

I have an idea for adapting the hourglass to our usecase. Will post here in a bit. Probably using the [wikipedia one])(https://commons.wikimedia.org/wiki/File:Hourglass_icon_%28orange%29.svg) since that looks the most like an icon,

marcwrobel commented 1 year ago

Ok, great.

captn3m0 commented 1 year ago

This was the plan, I didn't do a good job of the editing though (The cuts should have been different, it looks like an imposed triangle right now).

eol-favicon

SVG

marcwrobel commented 1 year ago

I really like what you did. The circle made me think a little bit to the Ubuntu logo (https://logosmarcas.net/wp-content/uploads/2020/11/Ubuntu-Emblema.png) ;).

Let's integrate this logo and see how it looks.

marcwrobel commented 1 year ago

@captn3m0, are you sure the SVG is the good one ? It is just a black circle when I look at it.

marcwrobel commented 1 year ago

Just gave it a shot following this tutorial : https://www.youtube.com/watch?v=JxIAXqbb5vQ. Got : logo-192x192

Updated the PR with (https://deploy-preview-1900--endoflife-date.netlify.app/), let me know if it's OK.

captn3m0 commented 1 year ago

SVG opens correctly for me in Firefox, so it should be correct, but your version is better regardless.

I think using the colored variant for Open-Graph, social images etc makes sense, while using a B/W variant for the favicon - I don't quite like the colored variant in the favicon.

Even better would be to have a dual-color SVG favicon that uses white for dark mode: https://blog.tomayac.com/2019/09/21/prefers-color-scheme-in-svg-favicons-for-dark-mode-icons/. Seems to have reasonable support (75% as per CanIUse)