Closed turadg closed 5 months ago
is that necessary?
It was the only solution I could find to the problem where eslint's default max-len
rule would get tripped up on the length of the Jessie preamble. Is there a way to tell the unused directive detector to ignore this rule?
Is there a way to tell the unused directive detector to ignore this rule?
I don't think so. Pretty rare case to have to support.
Could the preamble have some newlines? Alternately, we could just assume nobody has max-len
enabled since it has been deprecated since v8.53.0: https://eslint.org/docs/latest/rules/max-len
Could the preamble have some newlines?
If there are any newlines, then eslint reports incorrect line numbers when an error or warning is detected.
Alternately, we could just assume nobody has
max-len
enabled since it has been deprecated since v8.53.0
Yes, that would be preferable. It's an easy fix, but requires prioritisation.
I tried to release with these changes but couldn't figure out the steps from https://github.com/endojs/Jessie/pull/109
In agoric-sdk we started reporting unused eslint directives. This mysterious one started showing up,
even though
max-len
isn't mentioned in the repo.It turns out it's just in files with
// @jessie-check
and it's due to this content prefixing: https://github.com/endojs/Jessie/blob/96cabd9b688f28c0ea7576124843b97998316e36/packages/eslint-plugin/lib/processors/use-jessie.js#L43@michaelfig is that necessary?