endojs / Jessie

Tiny subset of JavaScript for ocap-safe universal mobile code
Apache License 2.0
281 stars 16 forks source link

params and ()s #6

Closed dckc closed 6 years ago

dckc commented 6 years ago

The definition of params already includes the ()s, but they appear again in the productions for functionExpr, functionDecl, etc.

Surely that's not on purpose.

https://github.com/Agoric/TinySES/blob/92f6766a1a392b82f85f5d4dc89f53f73ce4dee9/src/tinyses.js#L285

erights commented 6 years ago

Thanks for catching this! Your PR has the right fix, but see the review comments.