search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

fix(exo)!: extra undeclared args dropped #1765

Closed erights closed 1 year ago

erights commented 1 year ago

Alternative to https://github.com/endojs/endo/pull/1764 experiment.

Of the options listed there, this one

Preserve the tolerant behavior, but not pass the values of the extra args through to the protected raw behavior method. This would preserve the input validation intent of method guards while still accommodating API growth and thus version slippage.

As suggested by @mhofman and @turadg

erights commented 1 year ago

Reviewers,

I made this a fix(exo)!: rather than a fix(exo): because it technically is a compat break. However, it is unlikely to currently be a compat break in practice, so let me know if you think I should remove the !.