endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
804 stars 71 forks source link

stream-node: there i fixed it (and also broke it) #1780

Closed kumavis closed 1 year ago

kumavis commented 1 year ago

idk what the correct fix is but,

fixed the issue where pet daemon would just hang loading bundle.js by

getting error in cli for yarn endo open familiar-chat ./demo/cat.js --powers HOST

SES_UNHANDLED_REJECTION: (Error#1)
Error#1: write after end

  at packages/stream-node/writer.js:141:15
  at new Promise (<anonymous>)
  at writeChunk (packages/stream-node/writer.js:139:39)
  at packages/stream-node/writer.js:107:21
  at async Promise.all (index 0)

SES_UNHANDLED_REJECTION: (Error#1)
Done in 1.04s.
kumavis commented 1 year ago

good news

:white_check_mark: node v16.20.1 :white_check_mark: node v18.13.0 :white_check_mark: node v19.9.0 :white_check_mark: node v20.0.0 :white_check_mark: node v20.2.0 :x: node v20.3.0 :x: node v20.4.0 <-- i was here :crying_cat_face: :x: node v20.5.0 :x: node v20.6.0 (TypeError#1: Cannot redefine property: Hub) :x: node v20.6.1 :white_check_mark: node v20.7.0

kumavis commented 1 year ago

culprit? https://github.com/nodejs/node/commit/feb5b0fef8def15c801e4b950d662d76f41ed52c

kriskowal commented 1 year ago

Thank you for chasing this horror down with me and my condolences for the lost time.