fix(compartment-mapper): Root alias search - Githubissues

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES

Apache License 2.0

829 stars 72 forks source link

fix(compartment-mapper): Root alias search #1791

Closed kriskowal closed 1 year ago

kriskowal commented 1 year ago

I’ve so far been unable to reproduce a problem @kumavis found in compartment-mapper with an obvious solution.

kumavis commented 1 year ago

history

originally no special case for "."
"." special case added here, adding candidate "./index.js" https://github.com/endojs/endo/commit/7e7a98e39e4ddb06a5f955ad1407e36888247b16#diff-7de3acb49671b7b9010b69fa9b7c2f3f6bb669f65f6c72ac9c8a5044628fffb5R44 in https://github.com/endojs/endo/pull/442
"." :scream_cat: special case incorrectly removed :scream_cat: and main candidate handled in infer-exports as externalAlias https://github.com/endojs/endo/pull/1374/commits/128eb406afd09e9c6c806a97796a0cebd74d5fd0
for commonjs, "." main candidate also set in infer-exports via internalAlias https://github.com/endojs/endo/pull/1374/commits/2fd471d2dcb2b4ea366e5d0e37d0a2292184e0cc

upon review looks like that was my fault, should have removed the condition instead of just the '.' case