fix(ses): use prepareStackTrace for error stack string

[mhofman]

closes: #1798

Description

Fixes Error.prepareStackTrace with the following behavior changes:

• If it generates a stack trace string, use it instead of generating our own
• do not leak the stack string if errorTaming is not 'unsafe'
  • but keep the workaround for depd and similar that return the callSites array
• Restore a made safe Error.prepareStackTrace that existed before SES loaded (e.g. Node.js uses it to enable source maps)

Security Considerations

This change defers to a prepareStackTrace set in the start compartment to generate SES stack strings. The assumption is that such overrides are vetted.

Scaling Considerations

The new implementation uses try/catch which is often more expensive, but it likely dwarfs in comparison to the call sites wrapping we are already doing.

Documentation Considerations

How should this change be documented? I somewhat expected this to be the behavior in the first place

Testing Considerations

Passes existing unit test.

Upgrade Considerations

None

[mhofman]

For reference, I think v8 does its own changes to Error for prepareStackTrace:

• https://github.com/nodejs/node/blob/v20.8.0/lib/internal/errors.js
• https://github.com/nodejs/node/blob/v20.8.0/lib/internal/bootstrap/realm.js#L435-L458

[erights]

For reference, I think v8 does its own changes to Error for prepareStackTrace:

Did you mean Node?

[kriskowal]

@mhofman You have a stamp and a request from @turadg to include this in the next release.

[mhofman]

This does not do what it's supposed to do, back to draft

[erights]

Hi @mhofman , after this had several approvals, you wrote:

This does not do what it's supposed to do, back to draft

Do you remember what the problems are?

As a draft this PR was not assigned. I went ahead and assigned myself, since I want to look at reviving it. I also left myself on as a reviewer FWIW.

[mhofman]

Do you remember what the problems are?

Yeah it didn't solve the problem. I think because Node.js verified that the prepareStackTrace function was not modified from its own.