endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

fix(compartment-mapper): fix for bundling of appended cjs exports #1833

Closed kumavis closed 1 year ago

kumavis commented 1 year ago

bug fix for bundler for supporting the following commonjs exports patterns

module.exports.abc = 123
exports.xyz = 456

Originally tried to fix it with https://github.com/endojs/endo/commit/7daba15b88752898ab1f9a1895d5cf479ea3575f but this was insufficient, need to add missing cells and update the * cell

not sure if this is the correct change or just a bandaid but it got tests passing