search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

[WIP] Shallow harden #1914

Open mhofman opened 10 months ago

mhofman commented 10 months ago

refs: #1686

mhofman commented 10 months ago

@erights the use of harden are already in separate commits, but hold off anyway, I'm more thoroughly rewriting the harden implementation to add hooks.

erights commented 10 months ago

What about https://github.com/Agoric/agoric-sdk/pull/8700 ? It, likewise, seems to be almost all improvements in the use of harden which would be valuable regardless, and could get merged early. Yes?

mhofman commented 10 months ago

The vast majority of of changes in this PR are just generic improvements in use of harden. If you could separate these into a distinct PR, we could probably review and merge that quickly.

@erights I have now done that in https://github.com/endojs/endo/pull/1939. While I have rebased this PR on top of that change (roughly), I do expect to rewrite it significantly to add hooks to fully separate harden from lockdown

mhofman commented 10 months ago

Now that #1939 is merged, please rebase this one for review brevity. Thx.

It's stacked by apparently GH is struggling and didn't update the base ...

erights commented 10 months ago

I think if you rebase -i onto current (post merge) master and push --force, that should clean it up. yes?