Closed erights closed 10 months ago
While I agree it's technically a breaking change, I'm wondering if this particular instance warrant the churn associated with a major version bump. @kriskowal opinions?
I do not have strong feelings about the breaking change sigil,
I got rid of it. Thanks.
refs: https://github.com/Agoric/agoric-sdk/pull/8136 refs: https://github.com/Agoric/agoric-sdk/issues/8096 refs: https://github.com/Agoric/agoric-sdk/blob/master/docs/env.md#DEBUG
Description
As explained at https://github.com/Agoric/agoric-sdk/issues/8096 , prior to this PR, eventual-send's use of the
DEBUG
option mistakenly split it on colons (':'
). This PR switches that one use to split on commas (','
) instead.Security Considerations
Following widespread conventions leads to fewer unpleasant surprises.
Scaling Considerations
none
Documentation Considerations
https://github.com/Agoric/agoric-sdk/blob/master/docs/env.md#DEBUG already speaks in terms of the value of
DEBUG
being a comma separated list. Prior to this PR, the endo implementation does not conform to that document. But the agoric-sdk implementation would still not conform until fixed by https://github.com/Agoric/agoric-sdk/pull/8136Testing Considerations
none
Upgrade Considerations
none