search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
804 stars 71 forks source link

fix(ses): Support an incomplete shimmed globalThis.process #1923

Closed gibson042 closed 8 months ago

gibson042 commented 8 months ago

Fixes #1917

Description

Updates packages/ses/src/error/tame-console.js to check for a globalThis.process.on function rather than assuming it when globalThis.process is defined.

Also updates general patterns for checking globalThis properties for better uniformity.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

n/a

gibson042 commented 8 months ago

@mhofman ready for re-review.

kriskowal commented 8 months ago

Eager to land! Thanks.