search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
804 stars 71 forks source link

ses: Permit Symbol.dispose, Symbol.asyncDispose #1927

Closed kriskowal closed 8 months ago

kriskowal commented 8 months ago

What is the Problem Being Solved?

Explicit Resource Management is Stage 3 and we should permit Symbol.dispose and Symbol.asyncDispose under Hardened JavaScript

mhofman commented 8 months ago

I thought they were already added in https://github.com/endojs/endo/pull/1578

kriskowal commented 8 months ago

I see now that they were and why my grep didn’t reveal them. Thanks.

dckc commented 8 months ago

what package versions should this appear in?

looks like ses 0.18.5 https://github.com/endojs/endo/blob/master/packages/ses/NEWS.md#v0185-2023-07-14

yes, that explains why someone reported seeing

Removing intrinsics.Symbol.dispose
Removing intrinsics.Symbol.asyncDispose

after doing yarn create @agoric/dapp --dapp-template dapp-offer-up demo: that depends on ses@0.18.4