endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

refactor(common): move low level utilities to @endo/common #1935

Closed erights closed 10 months ago

erights commented 10 months ago

closes: #XXXX refs: #1815

Description

Successor to https://github.com/endojs/endo/pull/1815 with utilities moved to a new @endo/utils package.

Note: I did not label this refactor(utils)!: ... because I intend to add reexports to keep compat before declaring this ready for review.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

kriskowal commented 10 months ago

I want this to be called @endo/score as a pun on underscore.

To allow manual minimization of the weight of a program’s dependency graph, each utility function should be separately importable, like @endo/score/list-difference.js.

erights commented 10 months ago

I want this to be called @endo/score as a pun on underscore.

No single entendre puns. I'll allow it if you also have some rationalization, however bizarre or awkward, why "score" is a sensible name for this package. ;)

kriskowal commented 10 months ago

I want this to be called @endo/score as a pun on underscore.

No single entendre puns. I'll allow it if you also have some rationalization, however bizarre or awkward, why "score" is a sensible name for this package. ;)

I can only appeal to the tradition of:

However, I cannot think of a winning pun on “score” that cuts it, which is a strike that really underlines your point. Scratch that.

erights commented 10 months ago

However, I cannot think of a winning pun on “score” that cuts it, which is a strike that really underlines your point. Scratch that.

I asked for a double entendre and got a meta entendre. Serves me right ;)

erights commented 10 months ago

On a slack channel, we settled on a package name of common