search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

fix type imports in 'marshal' package #1940

Closed turadg closed 10 months ago

turadg commented 10 months ago

Description

In a recent review it came up that type imports to @endo/marshal were coming through as any. https://github.com/endojs/endo/pull/1928#discussion_r1445345893

The cause was that the maxNodeModuleJsDepth was 0, the default for tsconfig.json (as opposed to 2 for jsconfig.json). This bumps it to 1 to get the types from @endo/pass-style.

It also adds a regression test, which failed before the change.

As a bit of housekeeping it also bumps some typescript deps and refreshes the coverage report.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

mhofman commented 10 months ago

@turadg any reason the PassableCap were restored, but not the Passable from #1928 ?

turadg commented 10 months ago

@turadg any reason the PassableCap were restored, but not the Passable from #1928 ?

Because only the PassableCap was mentioned in the linked thread.

They're both any until https://github.com/endojs/endo/pull/1933 so I don't think it's worth more attention atm.