search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
804 stars 71 forks source link

define Key, PureData using parameterized Passable (WIP) #1952

Open dckc opened 8 months ago

dckc commented 8 months ago

suggestions for #1933

I think the pass-style stuff is complete. The patterns stuff is just a start.

The marshal stuff is probably superfluous.

turadg commented 8 months ago

@dckc I rebased https://github.com/endojs/endo/pull/1933 on top of master so I rebased this PR on top of that. https://github.com/endojs/endo/tree/ta/dc-Passable-types has the result.

I don't totally get what it buys. Does it make sense to try getting #1933 into master and coming back to this?

dckc commented 2 months ago

I think that's not even a functional change. The Exclude<...> is redundant: the never already says that.

So it's just a refactor for clarity/conciseness.

A few type tests to show that the types are equivalent might be worthwhile.