fix: "x" parameter in many tests is optional - Githubissues

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES

Apache License 2.0

829 stars 72 forks source link

fix: "x" parameter in many tests is optional #1965

Closed erights closed 10 months ago

erights commented 10 months ago

closes: #XXXX refs: https://github.com/Agoric/agoric-sdk/pull/8745

Description

At https://github.com/Agoric/agoric-sdk/pull/8745#discussion_r1451052306 @dckc noticed that an optional x parameter should have been declared optional but was not. Turns out that I had copy-paste-modify that mistaken declaration to other tests.

This PR fixes the ones in endo. https://github.com/Agoric/agoric-sdk/pull/8750 the ones in agoric-sdk

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

more accurate static types should help us generate more accurate docs

Testing Considerations

none

Upgrade Considerations

none

erights commented 10 months ago

very well

though I doubt we'll generate docs from these tests

Fixed PR comment. Done.