refactor(ses): cleaner enable-property-overrides - Githubissues

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES

Apache License 2.0

829 stars 72 forks source link

refactor(ses): cleaner enable-property-overrides #1975

Closed erights closed 9 months ago

erights commented 9 months ago

closes: #XXXX refs: #1969

Description

At https://github.com/endojs/endo/pull/1969#pullrequestreview-1823695473 @mhofman suggests:

As a matter of process, I would really prefer if independent changes were in separate commits. The change to the property override logic is great, but it seems it could easily stand in its own commit.

Because it is so separate, I made it into a this separate PR.

At https://github.com/endojs/endo/pull/1969#discussion_r1453556803 @mhofman suggests better code for that part of #1969. This PR uses that suggestion.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

none

Upgrade Considerations

none

erights commented 9 months ago

Got it wrong. Back to draft for the moment.

erights commented 9 months ago

Fixed. I followed exactly your original suggestion. My attempted improvement was just confused.

Ready for review again. Btw, I squashed which seems harmless for this review.