endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

optimized base64 operations on Node.js #1999

Open mhofman opened 9 months ago

mhofman commented 9 months ago

What is the Problem Being Solved?

encodeBase64 and decodeBase64 use the JS implementation on Node.js when there exists a native implementation using Buffer.

Description of the Design

feature test the Buffer global and use it, or rely on exports to only load the Buffer based implementation on Node

Security Considerations

None?

Scaling Considerations

Much faster than the JS implementation

Test Plan

Yes

Upgrade Considerations

Not quite sure if there are any.