search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

Ecosystem Compatibility (2024-02-05 onward) #2037

Open kriskowal opened 9 months ago

kriskowal commented 9 months ago

Index of ecosystem compatibility notes from 2021-02-10 to 2024-02-05 https://github.com/endojs/endo/discussions/1950 with updates to follow in subsequent comments and separate issues with the label ecosystem-compatibility.

naugtur commented 8 months ago

TODO: https://github.com/isaacs/minimatch/blob/ef8f2672bdbbf6a632ea815636659fb31b5169aa/src/index.ts#L1012

gibson042 commented 8 months ago

TODO: https://github.com/isaacs/minimatch/blob/ef8f2672bdbbf6a632ea815636659fb31b5169aa/src/index.ts#L1012

PR for that is at https://github.com/isaacs/minimatch/pull/228

kriskowal commented 8 months ago

mimic-fn does not compose well with our toString enablements. This manifests as a “Cannot define property with both value and get” (effectively). I have proposed a fix: https://github.com/sindresorhus/mimic-function/pull/51

ljharb commented 8 months ago

wouldn't that fix end up setting writable to false when it's a getter, because there's no writable in the first place? or is that fine

kriskowal commented 8 months ago

wouldn't that fix end up setting writable to false when it's a getter, because there's no writable in the first place? or is that fine

That’s a good question for @sindresorhus and the intended outcome for mimic-function. I think mirroring a getter with a non-writable value is possibly consistent with the intent.

erights commented 7 months ago

See https://github.com/endojs/endo/issues/2033#issuecomment-2028956104

Should https://github.com/endojs/endo/issues/2033 be tracked here as an endo ecosystem compat issue?