Previously, throwsAndLogs would only support testing against a literal golden. But for testing the initial-removal-log-messages, this was too fragile, since new engines might have added new properties whose removal would general additional initial-removal-log-messages. This PR enable the caller to provide an alternative compare function. That one test then uses this flexibility to tolerate additional warnings interspersed between the golden warnings it looks for.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The whole point. This enables us to turn an annoying test.skip back into the needed test.
Compatibility Considerations
Enables the test to remain compatible with benign future engine versions.
Upgrade Considerations
none.
Nothing breaking.
No news updates warranted.
[ ] Includes *BREAKING*: in the commit message with migration instructions for any breaking change.
closes: #1973 refs: #XXXX
Description
Previously,
throwsAndLogswould only support testing against a literal golden. But for testing the initial-removal-log-messages, this was too fragile, since new engines might have added new properties whose removal would general additional initial-removal-log-messages. This PR enable the caller to provide an alternative compare function. That one test then uses this flexibility to tolerate additional warnings interspersed between the golden warnings it looks for.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The whole point. This enables us to turn an annoying
test.skipback into the neededtest.Compatibility Considerations
Enables the test to remain compatible with benign future engine versions.
Upgrade Considerations
none.
Nothing breaking. No news updates warranted.
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.