endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
829 stars 72 forks source link

build: specify Yarn version by corepack #2050

Closed turadg closed 9 months ago

turadg commented 9 months ago

no ticket

Description

My environment has Yarn v3 installed globally and when I ran yarn install it errored with,

➤ YN0070: Migrating from Yarn 1; automatically enabling the compatibility node-modules linker 👍

Internal Error: Duplicate workspace name ses: /opt/agoric/endo/packages/ses conflicts with /opt/agoric/endo

To specify the Yarn version, this adopts Corepack. It's what the Yarn docs recommend and it's been available in Node since 16.9.

While it's not necessary in Yarn v1, the duplicate "ses" package name seemed to be asking for trouble so I removed it from the project root. It doesn't need to be named since it is private.

Security Considerations

Rely on Node environment for packageManager instead of source control

Scaling Considerations

n/a

Documentation Considerations

Aligns with current best practices

Testing Considerations

CI suffices

Compatibility Considerations

Package manager isolated to this repo, and perhaps cross-repo integration tests, but those will be caught by CI

Upgrade Considerations

n/a