endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
804 stars 71 forks source link

style(pass-style): Reduce nesting depth for input validation #2097

Closed gibson042 closed 7 months ago

gibson042 commented 7 months ago

Description

Reduce the nesting depth for input validation by defining rejects as tag functions rather than traditional wrappers.

Security Considerations

n/a

Scaling Considerations

Constructing details is already in the slow path exercised only with an explicit check function, and introducing rest/spread to the wrapper imposes minor additional cost (the reject call itself gets about 6% slower on XS and 20% slower on V8). We could probably do better by passing reject functions rather than constructing them at each level, but that would affect the public API so I'm not contemplating that here.

Documentation Considerations

n/a

Testing Considerations

n/a

Compatibility Considerations

n/a

Upgrade Considerations

n/a