endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
828 stars 72 forks source link

upgrade TypeScript to 5.4 #2135

Closed turadg closed 7 months ago

turadg commented 8 months ago

Description

https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/

Security Considerations

No change

Scaling Considerations

n/a

Documentation Considerations

Unnecessary

Testing Considerations

CI suffices

Compatibility Considerations

none

Upgrade Considerations

none

kriskowal commented 8 months ago

I see nothing in here that can possibly break Agoric SDK but I’ve guessed wrong before. Your discretion. I think there are some bundleSource type issues on endo/master that need to be resolved anyway and you might see a false negative.

turadg commented 8 months ago

I see nothing in here that can possibly break Agoric SDK but I’ve guessed wrong before. Your discretion.

Any changes to the types that are output will be correcting problems. While I don't expect it to cause any work for agoric-sdk if it does that will be fixing bugs. If it's onerous for the sync process I will do it.