endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
788 stars 70 forks source link

hang: waiting for bundle read lock #2163

Closed dckc closed 4 months ago

dckc commented 4 months ago

Describe the bug

A dev reports that they're experimenting with changes to the contract in dapp-offer-up. When running yarn test they see and endless series of

bundles/ waiting for bundle read lock: /Users/NNN/projects/learn/demo/contract/bundles/bundle-assetContract-js.lock in /Users/NNN/projects/learn/demo/contract/src/offer-up.contract.js

Steps to reproduce

the above is what we have

Expected behavior

tests should run

Platform environment

not reported

Additional context

cc @kbennett2000 @kriskowal

dckc commented 4 months ago

work-around: remove bundles directory

rm -rf bundles made the symptoms go away

kriskowal commented 4 months ago

The bundle read lock does not exist on the most recent releases of @endo/bundle-source. This might be solved by an upgrade.

dckc commented 4 months ago

ok... let's track this as a dapp issue, then:

dckc commented 4 months ago

The bundle read lock does not exist on the most recent releases of @endo/bundle-source.

I'd like to cite evidence of that and close this issue. I looked in the bundle-source changelog without luck.

Ah... I suppose this works:

Replaces the lockfile mechanism with atomic renames. -- https://github.com/endojs/endo/pull/1732

That suggests it's fixed in v2.80 2023-09-12.