search

endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
768 stars 68 forks source link

import types #2192

Closed turadg closed 3 months ago

turadg commented 3 months ago

Description

Uses @import from upcoming TS 5.5, like https://github.com/Agoric/agoric-sdk/pull/9149

Also includes the changes needed in https://github.com/Agoric/agoric-sdk/commit/83db366359540c651fad9b7e3c192e7aa92634ea

Security Considerations

Nightly build of TypeScript

Scaling Considerations

no runtime changes

Documentation Considerations

nothing to change

Testing Considerations

CI

Compatibility Considerations

Increases compatibility with agoric-sdk

Upgrade Considerations

no runtime changes

erights commented 3 months ago

Ecstatic. I think I found the CI failure. Your changes were mechanical, but there was an existing type reference error that had gone unnoticed somehow. I changed one imported type from Remotable to RemotableObject and appended that commit to your branch (1faea7a). Paging @erights if that’s consistent with the design.

Yes. Glad to see this happening!

erights commented 3 months ago

windows-latest failed. But it is known to be flaky so I restarted it.

turadg commented 3 months ago

I changed one imported type from Remotable to RemotableObject and appended that commit to your branch (1faea7a)

Thanks. I squashed that into the commit that has the others.

I also added the patch that agoric-sdk needed. Since you reviewed that in https://github.com/Agoric/agoric-sdk/pull/9185 @kriskowal I'm not requesting re-review before merging.

erights commented 3 months ago

Just reran the flaky windows-latest again