upgrade to Yarn 4 - Githubissues

turadg commented 2 months ago

closes: #2245 refs: https://github.com/Agoric/agoric-sdk/issues/451 refs: https://github.com/Agoric/ui-kit/pull/105

Description

Move from Yarn 1 to Yarn 4. Some advantages,

actively maintained
workspace protocol (so we don't have to maintain version numbers in all deps)
patch protocol (so we don't need patch-package)
constraints (e.g. to enforce layering)
path to adopt pnpm-style linker (without changing the UI) (see https://github.com/endojs/endo/pull/1722 )

However this defers workspace protocol until the publishing workflow can support it.

Security Considerations

This does a bulk update of yarn.lock. It was automated by Yarn 4.

Scaling Considerations

n/a

Documentation Considerations

I reviewed yarn commands in *.md and I think they're all accurate.

Testing Considerations

This could interact with the publishing pipeline. @kriskowal may want to push a draft before we merge. If problems are found, depending on the severity, we could follow up in a separate PR to land this sooner reduce merge conflicts.

This was failing on the Windows tests, something about corepack not taking effect. I don't know whether Windows is officially supported by Endo. We've since disabled them. https://github.com/endojs/endo/issues/2243 is the issue restore.

Compatibility Considerations

Some CLI commands are slightly different. We are adopting it across the org so we have to adjust sometime.

Upgrade Considerations

n/a

kriskowal commented 2 months ago

I’m interested in giving this a shot (and willing to suffer reverting it if it gets in the way of the sync cycle).

I’m reluctantly willing to entertain dropping Windows from CI to unblock this (and reduce occurrences of flakey tests that Windows CI reveals more often than Linux.) Windows support is hard to get back once lost.

May I ask for an Agoric SDK CI job pinned to this branch?