endojs / endo

Endo is a distributed secure JavaScript sandbox, based on SES
Apache License 2.0
761 stars 68 forks source link

chore(nat): Fix typo in Nat error message #2300

Closed gibson042 closed 1 month ago

gibson042 commented 1 month ago

Description

Adds a missing "is" to an error message from Nat.

Security Considerations

None.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

None.

Compatibility Considerations

n/a

Upgrade Considerations

We expect error messages to change over time and require code to be tolerant of this.

erights commented 1 month ago

We expect error messages to change over time and require code to be tolerant of this.

Just grepped for "not a safe integer" and verified that none of our endo or agoric-sdk code should have a problem with this change. This change also makes the error more consistent with other errors in agoric-sdk https://github.com/Agoric/agoric-sdk/blob/cc2bf0bb431aa64c601628f53cf191fcc84c5750/packages/ERTP/src/displayInfo.js#L26