search

endolith / elsim

Election Simulator 3000: Simulates a variety of elections and voting methods
https://endolith.github.io/elsim
MIT License
7 stars 4 forks source link

Add 95% CI error bars to CE and CW examples #14

Open endolith opened 2 years ago

endolith commented 2 years ago

https://stats.stackexchange.com/questions/576491/how-to-calculate-the-accuracy-of-a-yes-no-monte-carlo-simulation-such-as-throwi#comment1064757_576491

https://github.com/endolith/elsim/issues/13#issuecomment-1197176430

sourcery-ai[bot] commented 1 year ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.49%.

Quality metrics Before After Change
Complexity 24.08 😞 25.80 😞 1.72 👎
Method Length 345.80 ⛔ 381.40 ⛔ 35.60 👎
Working memory 20.21 ⛔ 20.84 ⛔ 0.63 👎
Quality 26.07% 😞 24.58% ⛔ -1.49% 👎
Other metrics Before After Change
Lines 371 395 24
Changed files Quality Before Quality After Quality Change
examples/merrill_1984_fig_2c_2d.py 8.36% ⛔ 7.09% ⛔ -1.27% 👎
examples/merrill_1984_table_1_fig_1.py 14.70% ⛔ 13.13% ⛔ -1.57% 👎
examples/wikipedia_condorcet_paradox_likelihood.py 73.55% 🙂 69.29% 🙂 -4.26% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9853fa) 97.40% compared to head (c93a525) 97.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14 +/- ## ======================================= Coverage 97.40% 97.40% ======================================= Files 18 18 Lines 463 463 ======================================= Hits 451 451 Misses 12 12 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.