endolith / waveform-analysis

Functions and scripts for analyzing waveforms, primarily audio. This is currently somewhat disorganized and unfinished.
MIT License
255 stars 82 forks source link

Have weighting curves been validated? #25

Open sammlapp opened 1 year ago

sammlapp commented 1 year ago

The README mentions that some parts of this repo have not been validated. This seems to be the best Python resource for A, C weighting of digital audio, and it would be useful if someone could confirm that the implementation is correct.

endolith commented 1 year ago

Validated in what way? I have scripts to compare it with the limits specified in the standards, and it meets them for a range of sample rates. Not sure if I put them on here or not.

Yes, the repo is disorganized and unfinished and I'm sorry about that. Ironically it's my most popular repo and also the worst. If more people bother me about it I'll prioritize cleaning it up.

I was thinking it might be better to just make a weighting_filter repo that does nothing but the weighting filters and is easily installable,etc. Would that be useful? See https://gist.github.com/endolith/148112?permalink_comment_id=3925961#gistcomment-3925961 for comments and graphs

endolith commented 1 year ago

In fact I started it https://github.com/endolith/weighting_filters

endolith commented 2 months ago

See https://github.com/berndporr/sound_weighting_filters instead

sammlapp commented 2 months ago

sorry for delay in replying, but thank you for that resource - it's certainly useful to me!

jonnor commented 1 month ago

The MZTi method is not included in the berndporr repository, nor in this one? And according to the graphs showed in the linked comments, that is the one that performed the best?

endolith commented 1 month ago

@jonnor Yeah it should probably be adopted and just document the discrepancies at low fs