endorh / smart-completion

Better Completion for Minecraft Commands
https://www.curseforge.com/minecraft/mc-mods/smart-completion
MIT License
4 stars 1 forks source link

[1.20.1 Forge] Locate structure does not autocomplete #1

Closed MrKashew closed 11 months ago

MrKashew commented 11 months ago

image however locate biome does image debug.log latest.log

endorh commented 11 months ago

Oh wow, that's surprising.

Seems like either the locate structure command is doing something weird or my mod is crashing/failing silently while sorting the suggestions.

I'll investigate it later, thanks for the report ^^

endorh commented 11 months ago

Alright, the difference between /locate biome and /locate structure was that the suggestions for /locate biome were being cached in the client, while those for /locate structure were being actually requested to the server (even in singleplayer). The vanilla handling for those requests was discarding all except the last one, so my way of sending two of them at the same time caused one of them to be discarded, and the completions to wait forever.

I've fixed it in the latest version (1.1.0), which should be already available on CurseForge. If you have the time, please confirm that the fix works for you.

MrKashew commented 11 months ago

verified fixed! thanks so much!