endroid / qr-code-bundle

Bundle for generating QR codes in Symfony
MIT License
286 stars 38 forks source link

Add qr-code to existing FPDF #51

Closed laurentmuller closed 3 years ago

laurentmuller commented 3 years ago

It will be nice if we can add a qr-code to an existing PPDF document. Maybe with an function like this:

public function addToFpdf(FPDF &$fpdf, float $x, float $y) {
   ...
}
endroid commented 3 years ago

Hi @laurentmuller thank you for your suggestion. I would like to keep the library and the writer interface as much FPDF agnostic as possible (as in: it the writer should ideally be replaceable with a different PDF library than FPDF). But if it can be done with not too many changes and the document can be passed via the $options array of the write method I am open to this feature.

laurentmuller commented 3 years ago

I have created a pull request within this enhancement.

endroid commented 3 years ago

Merged, thank you!