search

endroid / qr-code

QR Code Generator
https://endroid.nl
MIT License
4.41k stars 725 forks source link

Option to add rounded border for EPC QR code #313

Closed ThomasLandauer closed 2 years ago

ThomasLandauer commented 3 years ago

When creating a QR code for payment, there's a "standard" in Austria to add a rounded border with some text in it - see https://www.stuzza.at/de/zahlungsverkehr/qr-code.html It looks like in Germany they have this too: https://www.girocode.de/girocodetools/pages/girosolution/ and on https://en.wikipedia.org/wiki/EPC_QR_code some other countries are mentioned as well.

Would you be interested in adding such a border (with user-defined text) to the library? Incidentally, an EPC QR code generator (using endroid/qr-code) just went live a few days ago: https://github.com/ccharz/laravel-epc-qr, and there's also https://github.com/smhg/sepa-qr-php I'm asking here first, cause such a border might be interesting besides the EPC use case as well.

endroid commented 3 years ago

Hi @ThomasLandauer I am not really interested in adding such a border myself but if someone wants to contribute and provides a clean solution I think this could be a nice addition to the library. Thank you for the suggestion.

endroid commented 2 years ago

I'm closing this ticket because of lack of input. However if anyone still wants to add this feature, feel free to reopen / make a PR.